[MPlayer-dev-eng] Re: [MPlayer-users] subtitle reader crashes on Solaris

[Alex Beregszaszi]

Hi,

> > -		    sprintf(tmpresult, "%s %s", f_fname_trim, tmp_sub_id);
> > +		    if (tmp_sub_id)
> > +		      sprintf(tmpresult, "%s %s", f_fname_trim, tmp_sub_id);
> > +		    else
> > +		      sprintf(tmpresult, "%s (null)", f_fname_trim);
> 
> Ever heard of: 'tmp_sub_id ? tmp_sub_id : "(null)"' ??
Btw, imho it should be fixed entirely, not with such hacks..

> It's much cleaner and more readable.
Agree.

-- 
Alex Beregszaszi <alex at fsn.hu>
(MPlayer Core Developer -- http://www.mplayerhq.hu/)