[MPlayer-dev-eng] [PATCH] vf_eq2 extensions (+ independant gamma)

[Hampa Hug]

Daniel Moreno wrote:

> Hampa Hug wrote:
> > Daniel: I think it should be possible to combine vf_eq2 and your
> > gamma patch into a single filter. This would then be a pretty
> > complete equalizer.
> 
> Yes. In fact, yesterday night I was taking a more in depth look at eq2 
> to add saturation and gamma, but you have already added almost all I 
> planned to do. Adding the gamma thing has been trivial.
> 
> There are just some things to note:
> 
> * Is there any of those "misterious" cache issues recomending against 
> processing u and v channels in different loops? Now, with my gamma 
> stuff, it is possible for one of those to require filtering but not the 
> other. So we'd save time.

I see no reason not to do it separately. Before your patch the
code was just simpler with one loop (before I saw your patch
there was only one LUT for U/V in my code).


> * Also... we've bosted the number of parameters from 3 to 8. Maybe it'd 
> be time for a more complex parameter parsing that would allow the user 
> to easily skip the params he doesn't care about?  :-m

ACK. Is there some standard/preferred way to do this?


> Here I provide the patch (against CVS, not against yours) to put 
> together all the filtering. My modifications have been minimal. ;)

Looks good to me.

Hampa