[MPlayer-dev-eng] [PATCH] Final (hopefully) 3d denoise patch

[Daniel Moreno]

Arpi wrote:

> ok applied, with lots of modifications.
> your code assumed that tere are always 2 mpi buffers, and so
> dmpi==previous_frame==destination_frame. it's bad.

Uhmmm... I really miss some sort of "conceptual overview" about all 
this. At least it'd provide a method (other than trial and error) for 
new coders to do things. But well... this "we'll not teach you until you 
already know it" sounds familiar from when I was on mplayer-users... }:)

> ok it's still far from being readable by a hardcore C coder...
> it reminds me to some pascal examples from an old programming book :)

This would explain my idea of C being an uglification of Pascal. I'm 
sorry if it's not of your taste, but I started writting clean code when 
all I got from reading my 1 month old code were aspirins.

>>* Updated DOCS/tech/vop.txt, so that people know it exists and how to 
>>use it. (should I update some other doc?)
> 
> manpage also should be updated, users do read that. vop.txt is for
> developers and/or advanced users

Users read proper manpages, but with mplayer they hunt everywhere for a 
bit of information, I think. Anyway... I've never written a manpage and, 
in fact, I don't even know if those are usually written by hand, with 
some sort of editor or a preprocessing tool. :-m


-- 
Daniel Moreno - ComaC
Port pa'Linux del FinalBurn: http://fblinux.emuunlim.com/