[MPlayer-dev-eng] [PATCH] GIF support, release quality?

[Arpi]

Hi,

> On Wed, Jan 29, 2003 at 11:09:02PM +0100, Arpi wrote:
> > > Yes, except that the format is still BGR8.  lavc and scale can be loaded
> > why?
> 
> Because paletted BGR8 still uses IMGFMT_BGR8.
> When vo sees BGR8, it assumes it's not indexed, but packed 1 byte ber pixel.
> This is not always true.

heh?
BGR8 is always indexed, which means it has palette (or if it has no palette
it's assumed grayscale)

> > > based on requested format or format incompatibilities.  How should
> > > mpcodecs_config_vo() be notified of the need to load vf_palette?
> > > vf_palette checks for a palette by checking for the number of planes in
> > > the mpi it gets, but mpi has not been built when mpcodecs_config_vo() is
> 
> > it has NOTHING with the palette or number of colors.
> > if the colorspace is BGR8 and the filter chain/vo driver doesn't accept BGR8
> > then you have to instert vf_palette. easy.
> 
> I'm sorry, but you are wrong about this.
no

> If the vo supports BGR8, but your video is BGR8 w/ palette, then you
> will see garbage on the screen without vf_palette.  There is not a

why?

> single vo available that takes note of a palette in plane 1.

bad

afaik only vo_svga and vo_ggi supports BGR8, and both (should) use the palette.
otherwise it has no sense of supporting bgr8, as you said it would show garbage.

> > because if the vo accepts BGR8, then inserting vf_palette is worse than
> > nothing.
> 
> No, if vo accepts BGR8 and ignores the palette, you see garbage.

Sure. But i don't think that any vo behaves so.
if yes, it means that _vo_ is broken.

> 2) make all vo's supporting BGR8 take notice of palette
yes


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino