[MPlayer-dev-eng] TODO for release? bugs status...

[Arpi]

Hi,

> Here is another iteration which seems to solve both issues.

sure? :)

i've tried to play 2 avi files, none of them have prescaling (aspect ratio
coded in file) but the first is 16:9 the second is 4:3 ratio.

mplayer file1.avi file2.avi
worx

mplayer -fixed-vo file1.avi file2.avi
worx, but the second file has wrong (16:9) aspect ratio.

mplayer -fixed-vo file1.avi file2.avi
while playing file1, press 'f' and then set panscan to 100%
file2 will result pure black screen.

now try the same, increase panscan but don't set panscan to 100%
file1 & file2 plays ok.

also, your change to saving panscan may break other vo drivers supporting
panscan (xmga etc) even without -fixed-vo :(
(-> bad idea in 0.90-rc times)

i vote for applying your first(!) patch, it fixed -fixed-vo
or applying second patch with fix for panscan.
this vo_panscan_start thing is not acceptable now :(

or just forget the whole thing. -fixed-vo is still experimental feature.
and after the release someone should go and re-design this whole -fs vs 'f'
vs panscan etc thingie.
all these flags should be changed to 3-state: yes, no, previous.
so user could override it (both force enable and disable) from commandline,
but by default it would preserve 'f', panscan etc states.
another problem is that vo_fs is actually an _internal_ variable of
x11_common's fs switching code, it shouldn't be read/write by vo drivers.
or we should change vo_x11_fullscreen to use vo_fs as parameter instead of
handling fs toggle itself. (so 'f' handler could do vo_fs=!vo_fs; vo_x11_fullscreen())

and at the same time remove the fullscreen flag from config()'s last
parameter or 'emulate' it by vo_fs for compatibility...


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino