[MPlayer-dev-eng] [PATCH] tremor: v2.0 some workaround for something

Balatoni Denes pnis at coder.hu
Tue Jan 28 22:38:55 CET 2003


Hi!

Thanks I tried it, the same problem with tremor.
I changed iirc 2 lines (attached as patch against current cvs) , and now 
tremor works, and normal libvorbis too - however less than minlength samples
are returned to dec_audio sometimes. I don't know why
break works and continue does not in the patch (there is a comment).

bye
Denes


On 2003. január 28. 20:40, Arpi wrote:
> Hi,
>
> note that i don't know vorbis API at all, but i assumed that:
> > +	  while((samples=vorbis_synthesis_pcmout(&ov->vd,&pcm))<=0){
>
> vorbis_synthesis_pcmout() always return the number of PCM samples available
> in codec's buffer, and it returns <=0 if no samples available yet
>
> and that
>
> > +	    op.bytes = ds_get_packet(sh->ds,&op.packet);
> > +	    if(op.bytes<=0) break;
> > +	    if(vorbis_synthesis(&ov->vb,&op)==0) /* test for success! */
> > +	      vorbis_synthesis_blockin(&ov->vd,&ov->vb);
>
> vorbis_synthesis+vorbis_synthesis_blockin always processes op.bytes bytes
> from op.packet.
>
> if these assumptions are wrong, then forget my patch, it won't work.
>
>
> A'rpi / Astral & ESP-team
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tremorv2.0.diff
Type: text/x-diff
Size: 1884 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20030128/3d1b05e6/attachment.diff>


More information about the MPlayer-dev-eng mailing list