[MPlayer-dev-eng] [PATCH] GIF support, release quality?

[Joey Parrish]

On Mon, Jan 27, 2003 at 10:57:07PM -0600, Joey Parrish wrote:
> On Tue, Jan 28, 2003 at 01:48:38AM +0100, Arpi wrote:
> > the third one is very bad, the right way of auto-adding 'palette' is the
> > one done for 'scale' and 'lavc' in vc.d
> I'll look at it again and see what I can do different.
I've looked it over, and I disagree about this.  Auto-adding scale
and lavc are due to colorspace mismatches.  If your vo supports
BGR8, then this will never happen.  There needs to be either some
way of the codec notifying the rest of mplayer that there is a palette
by setting a flag, or paletted colorspaces need to be different from
standard BGR8.  Otherwise, I see no way to detect the existance of a
palette and know when to auto-load vf_palette.  Another solution could
be to stop appending the palette to BIH and make a place for it.  A new
field could be checked for a NULL pointer to find the palette, but
appending the palette to BIH leaves no way to know if it's there.
The current way of handling palettes feels like a hack to me.

> > btw it doesn't work ok for me, colors are wrong.
> > try this one: http://www.distrowatch.com/images/banners/uhu.gif
> Thanks, I'll see if I can figure out the problem.
With latest unpatched CVS the colors of uhu.gif work fine with
vf_palette.  I cannot reproduce.  Maybe your vo has issues?

--Joey