[MPlayer-dev-eng] Re: [bug] help/help_diff.sh again

[Arpi]

Hi,

> Hey, did anyone read this!?

yes, but i didn't like it...

what if someone has no external echo command? or it isn't at /bin/ but
somewhere else? (/usr/bin/ for example, like here)

imho sth like

ECHO=`which echo`
if -z $ECHO ; then
  ECHO='echo'
fi

should be added at least

> 
> On Sat, Jan 11, 2003 at 18:16:17 +0100, GoTaR wrote:
> 
> > ----------------------------
> > revision 1.6
> > date: 2003/01/03 12:14:34;  author: nexus;  state: Exp;  lines: +3 -3
> > FreeBSD fix
> > ----------------------------
> > 
> > If -E echo parameter is unavailable in FreeBSD we have to use external
> > echo instead of builtin; the latter in pdksh and zsh behaves
> > differently as I wrote lately. Patch attached.
> 
> Reattached.
> 
> -- 
> GoTaR <priv0.onet.pl->gotar>
> PLD stuff at http://mops.uci.agh.edu.pl/~gotar/
> 
> 
> 
> ***************r-e-k-l-a-m-a**************
> 
> Chcesz oszczedzic na kosztach obslugi bankowej ?
> mBIZNES - konto dla firm
> http://epieniadze.onet.pl/mbiznes
> 
> --- /home/gotar/cvs/mplayer/help/help_diff.sh	Fri Jan  3 13:50:53 2003
> +++ help_diff.sh	Fri Jan 10 18:24:46 2003
> @@ -9,8 +9,8 @@
>  curr=""
>  
>  while read -r line; do
> -	if echo "$line" | grep -q '^#define'; then
> -		curr=`echo "$line" | cut -d ' ' -f 2`
> +	if /bin/echo "$line" | grep -q '^#define'; then
> +		curr=`/bin/echo "$line" | cut -d ' ' -f 2`
>  		if grep -q "^#define $curr " $1; then
>  			curr=""
>  		fi
> @@ -21,8 +21,6 @@
>  	fi
>  
>  	if [ -n "$curr" ]; then
> -		echo "$line"
> +		/bin/echo "$line"
>  	fi
>  done
> -
> -
> 
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 
> 


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu