[MPlayer-dev-eng] [PATCH]Fix subcp crash(hopefully)

[陆然]

Hi,

On Tuesday 14 January 2003 17:40, Arpi wrote:
> Hi,
>
> > I think the bug is this, I test mplayer with a Chinese subtitle in ssa
> > format, since Chinese charactor use two byte to store one char, maybe
> > half of the Chinese char looks like '{', then it will be eliminated. the
> > other half char remain in subtitle cause iconv crashed. So I change the
> > code to eliminate
>
> hmm. what about doing { } removal _after_ the iconv conversion?
>
> in packed charsets like UTF8 any random char may be there...

I'm afraid then ssa should be handled separately. In other format {} should 
not be removed, maybe they are part of the subtitles. Maybe the better way is 
to add more test point before remove anything from subtitle. But I don't have 
a ssa sub with {}, so I don't know what kind of info can be used to test it.

-- 
Best Regard,
LR