[MPlayer-dev-eng] "tremor" broken

[Balatoni Denes]

Hi!

I mentioned before on cvslog that it was broken. The problem
is that due to the multiplication for gain some bits are clipped.
Rémy looked into it, said it was correct, so I assumed I was halucinating.:)
Without gain support in ad_vorbis it was fine for me - or an accuracy of 5 
bits was ok too.

bye
Denes


On 2003. január 13. 18:26, D Richard Felker III wrote:
> Yeah, although I was the one to initially advocate it, I must admit
> that the "tremor" integer-only vorbis decoder is totally broken. It
> clips like crazy on high-amplitude source files, and as far as I can
> tell the clipping isn't mplayer's fault. In the meantime I'll see if I
> can fix up ad_libvorbis.c to at least do fast float->int conversion
> hacks, but IMHO, unless libavcodec is getting its own independent
> vorbis decoder very soon, we should import tremor into mplayer CVS and
> fix it. That would be nice too because the code is fairly small and it
> would make mplayer support ogg out of the box without extra libs.
> Opinions, anyone? Should I upload files that make tremor clip to mphq?
>
> Rich
>
>
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng