[MPlayer-dev-eng] [PATCH] Support for MOV-Reference Files

Arpi arpi at thot.banki.hu
Sun Jan 12 22:07:37 CET 2003


Hi,

> attached patch adds support for MOV-Reference-Files ...
nice

> It uses the video->stream for doing so and makes sure that type is set to 
> TYPE_PLAYLIST ...
ok

> It also makes sure, that unnecessary items like qt5gateQT are removed and that 
> the url/basepath is added to "local files" ... (There should be a fix to also 
> test for ../bla and so on ...)
ok

btw afaik these reference files contain the same video in several
resolutions/formats/bitrates, so maybe insteda of adding all them to the
playlist, we should select the best?

> For this and t hat is one drawback of the patch it uses basename, which needs 
> libgen.h which is only available on linux-systems ...
bad!!!

> So we need our own function to do this ... (native implementation)
shouldn't be hard, the dirname(0 (also from libgen) impl. was 5 lines...

> It also changes some network code:
> 
> If mime/type==video/quicktime and video is bigger than normal set cache (40 
> kb), cache-size is set to Content-Length ...

BAD!!!

> PS: I hope it is clean and there are no 10l's in for example the code with the 
> basename-thingy (I really don't like string-handling, I really don't ;) )
ask .so for help :)))

>    demuxer=new_demuxer(stream,DEMUXER_TYPE_MOV,audio_id,video_id,dvdsub_id);
>    if(mov_check_file(demuxer)){
>        mp_msg(MSGT_DEMUXER,MSGL_INFO,MSGTR_Detected_XXX_FileFormat
> ,"QuickTime/MOV");
> -      file_format=DEMUXER_TYPE_MOV;
> +      if (demuxer->type==DEMUXER_TYPE_PLAYLIST)
> +        file_format=DEMUXER_TYPE_PLAYLIST;
> +      else      
> +        file_format=DEMUXER_TYPE_MOV;

this is not needed, new_demuxer() sets demuxer->type to its 2nd parameter...
just remove that nonsense/useless file_format=DEMUXER_TYPE_MOV;
line


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu


More information about the MPlayer-dev-eng mailing list