[MPlayer-dev-eng] [PATCH] Fallback to playlist after all demuxers (now with forced :-)))

Fabian Franz FabianFranz at gmx.de
Sun Jan 12 00:51:17 CET 2003


Am Samstag, 11. Januar 2003 22:24 schrieb Arpi:
> Hi,
>
> > this patch adds an fallback to playlist after all demuxers failed ...
> >
> > However I think the message: "Sorry, this file format is not
> > recognized/supported" will after that change never appear :-(( because
> > textplain-playlist is too stupid ...
> >
> > I vote for an variable to set textplain parsing to optional ... (useful
> > in fallback, not useful when spcifically using -playlist)
> >
> > However I don't now what you think about it ?
>
> imho that parse_playtree() thingie should have a parameter like 'int
> forced', set to 1 if called with -playlist, and set to 0 if called after
> demuxers failed. it shouldn't try unreliable parsers (like the stupid
> plaintext-list) for force==0.

ok, added to patch... See attached one :)

>
> also the other parsers should be reviewed and more sanity checks added.

I reviewed them all and they are clean (unless some binary file has some 
specific text + new line in first line ;-))
>
> > Index: mplayer.c
>
> ok the patch looks clean.
> (as clean as a patch for this mess can be :))

thx :)

So you could now commit ... ;) (attached patch, after reviewing of course ...)

cu

Fabian

>
>
> A'rpi / Astral & ESP-team
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer_fallback_to_playlist_with_forced.diff
Type: text/x-diff
Size: 7281 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20030112/e4408529/attachment.diff>


More information about the MPlayer-dev-eng mailing list