[MPlayer-dev-eng] [PATCH]: Fallback to null video codec

Arpi arpi at thot.banki.hu
Fri Jan 10 13:52:53 CET 2003


Hi,

> Some time ago I was complaining about crashing of mplayer when:

when?

>  if(!sh_video->inited){
>      mp_msg(MSGT_DECVIDEO,MSGL_HINT, MSGTR_TryUpgradeCodecsConfOrRTFM
> ,get_path("codecs.conf"));
>      mp_msg(MSGT_DECVIDEO,MSGL_ERR,MSGTR_CantFindVideoCodec,sh_video->format);
> +    // fall back to null when codec is not found
> +    init_video(sh_video,"null",NULL,-1);
>      return 0; // failed
>  }

no, this is wrong.
look at that return 0;

mplayer should not play (not even demux) video at all, if the
codec init failed.

what fileformat and -vo driver you used for reproducing this bug?
don't say any, i cannot reproduce it here.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu


More information about the MPlayer-dev-eng mailing list