[MPlayer-dev-eng] [PATCH] Compiler warnings almost gone :)

[Dominik Mierzejewski]

On Friday, 10 January 2003, Alex Beregszaszi wrote:
> Hi,
> 
> > After the last few patches I'm almost done with eliminating compiler
> > warnings. :) Only a few worth mentioning remain. Two, in particular,
> > are probably easy to fix by the maintainers:
> > 
> > pl_format.c:231: warning: suggest parentheses around + or - inside
> > shift vo_dga.c:580: warning: suggest parentheses around && within ||
> > 
> > Is the attached patch a good fix?
> 
> The vo_dga fix should be trivial, but the pl_format not.
> I think it should be (1<<31)-1 instead your version ( (1<<(31-1)) ).

Maybe so, but according to C standard - has higher priority than <<, so it
was executed in that order anyway. I don't pretend to understand this code,
so I don't know what is the right solution here.

> Anyway, do not commit it wihtout Anders answer.

Sure, just asking.

-- 
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"