[MPlayer-dev-eng] [BUG] surround audio plugin broken

Anders Johansson ajh at watri.uwa.edu.au
Fri Jan 10 02:54:55 CET 2003


> Hi
> 
> On Thursday 09 January 2003 03:31, Anders Johansson wrote:
> [...]
> > > hmm, seems its a bit more tricky to optimize
> > > the problem:
> > > the circular buffer is filled 1 sample at a time and then these are
> > > immediatly used in the FIR filter, this makes MMX&SSE useless as there
> > > are large penalties for reading something which was written with a
> > > different size immedeately before, i ll try to use a larger buffer and
> > > prefill it before running the FIR filter over it ...
> >
> > Make sure it still works if there is only 1 new input sample.
> ok, but how do i force that the resample filter is feeded with 1 new sample at 
> a time?
> 
> >
> > > btw, is
> > > #define ADDQUE(xi,xq,in)\
> > >   xq[xi]=xq[xi+L]=(*in);\
> > >   xi=(xi-1)&(L-1);
> > > correct?
> > > shouldnt it be
> > > #define ADDQUE(xi,xq,in)\
> > >   xi=(xi-1)&(L-1);\
> > >   xq[xi]=xq[xi+L]=(*in);
> > > ?
> >
> > Yes I think so. I'll apply the matlab script I used to develope the
> > algorithm.

Sorry I wasn't clear, what I meant to say was that I think you are
right, I'll be happy if you can correct the error. BTW: You should be
able to hear the difference (use upsampling (4 times or more) and use
headphones).

> Michael

//Anders



More information about the MPlayer-dev-eng mailing list