[MPlayer-dev-eng] [Patch] Loading of Voxware Codec

[Arpi]

Hi,

> > > Every since mplayer gained the ability of playing the Sorenson 3 codec
> > > (good job guys!), the loading of the DShow Voxware codec have been
> > > broken. After looking through some of the code (I am not a programmer,
> > > but I can usually figure out what is going on) I have found and fixed the
> > > problem. Attached is the fix.
> >
> > thank you very much, applied!
> 
> I don't understand this patch at all ...

it turned out to be bad patch (it broke qt) but i've already fixed it few
days ago.

> I would think: (HANDLE) is resolved to HANDLE and then multiplicated by 0 ?!
> 
> hm, or is it resolved to HANDLE0 but what then ?

msdn says that it should return (HANDLE)-1 if no files found, and return any
other value (to be passed to findNEXTfile() as parameter handle) if success.

so, actually 0 (or NULL) is a valid handle here...

i think they handle 'handle' as opaque, teh caller don't even know its type.
it only knows that if findfirstfile returns -1 then it failed, otherwise
it's ok


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu