[MPlayer-dev-eng] [BUG] surround audio plugin broken

[Arpi]

Hi,

> > > > > Disagree, resampling when the movie is 48000 hz and the soundcard only
> > > > > supports 44100 should be done by default, just like -vop scale is
> > > > > auto-inserted when the output device is rgb. Otherwise the output is
> > > > > just wrong.
> > > > 
> > > > yep. but for example automatic resampling of 44100 to 44098 is just dumb.
> > > > (and slow and causes big delay and whatever)
> 
> Perhaps the sloppy switch in resample should be enabled by default.

hmm, what's that? anyway yes, do it :)

> > maybe we should change all codecs to output in their native formats only,
> > and left all kind of downsampling, float2int etc to libaf.
> 
> I think this is a good idea. I'll be happy to do my bit of the work.

maybe the first step should be optimized float2int in libaf.

> > mono decoding of stereo sterams, stereo decoding of mono streams).
> > but this way we could ask the soundcard to accept the codec's native format,
> > and do the conversion only if it cannot be done. if both codecs & ao
> > supports float, then prefer float in filters, otherwise if both codec & ao
> > are integer, then don't convert it to & back from float, it just eats cpu.
> > if the user wants hi-fi quality, he can still force float filters on
> > commandline.
> 
> Should I make the filters convert to float depending on the -format switch
> rather than depending on CPU speed perhaps?

yes.
this way users still can force float processing with -format


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu