[MPlayer-dev-eng] [PATCH] TV & DXR3: mencoder works but mplayer does not
makovick at kmlinux.fjfi.cvut.cz
Sat Jan 4 18:23:30 CET 2003
Jaroslav Tulach wrote:
> Sorry if this message comes twice.
> few days ago I have cried on user mailing list that I can record from a
> TV card with sound, but I cannot hear the sound during playback, I have
> just investigated the problem and here is a patch to make everything
> work. I'll be graceful if you could review it, improve it and
> integrate it.
Unfortunately, it doesn't work well with anything else than ao_SDL.
> Problem description:
> mencoder -tv
> -ovc lavc -lavcopts vcodec=mpeg4:vbitrate=900 -oac mp3lame -lameopts
> cbr:br=32 -o Y.avi
> works fine, but
> mplayer -vo dxr3:noprebuf -ao oss:/dev/em8300_ma -tv
> does not. The reason for this is that mplayer.c sets tv_param_immediate
> = 1 and then the tv_v4l.c driver disables the sound completely.
Yes I know that. I disabled it completely because i didn't know how to
solve the sync problems. (and it wasn't necessary for me as I use an
external loopback => no motivation for spending time).
> I am looking forward to see conflict during cvs upd indicating that my
> patch was integrated ;-)
No, I won't commit this in the current form.
> PS: In tvi_v4l.c there is a code:
> case TVI_CONTROL_IS_AUDIO:
> if (priv->channels[priv->act_channel].flags & VIDEO_VC_AUDIO)
> which I think has wrong last line. It should be return FALSE, is it not?
Thanks, I'll review it.
More information about the MPlayer-dev-eng