[MPlayer-dev-eng] -geometry code and -vo fbdev broken

[Joey Parrish]

On Sun, Feb 23, 2003 at 04:07:27PM +0100, Michael Niedermayer wrote:
> :(, IMHO vo's shouldnt do such conversion themselfs, instead the video filter 
> layer should do it, but if ppl disagree then ill fix all the affected vo's so 
> that they use the swscaler internally for the conversion (the yuv2rgb code 
> uses the swscaler context now ...)

vo_gif89a uses yuv2rgb internally because it benefits from slices, but
has to output everything in rgb.  Rendering the slices rather than full
frames gives a noticable speed improvement when ripping to gif.  Also,
there is potential to code something a lot like slices into the output
gif, which would save a lot of space through motion compression.
vo_gif89a does not currently do this, but it could be added in the future.
(If I get around to gif hacking again this semester.)

I vote that gif89a and other vo's that have similar needs should be
fixed to use swscale.  (Which, without RTFS I don't know how to do.  I'm
currently working on more cygwin issues/testing, but if the vo is still
broken later tonight, I'll probably figure it out and send a patch.)

> otherwise slices + vf should be fixed and the yuv2rgb code should be removed 
> from the VOs
> 
> [...]
> 
> Michael

Thanks,
--Joey