[MPlayer-dev-eng] [PATCH] vo_vm_close() improper cleanup

[Attila Kinali]

On Mon, 24 Nov 2003 18:25:42 +0100 (CET)
Peter Kosinar <goober at ksp.sk> wrote:


> *** libvo/x11_common.c:vo_vm_close() & vo_vm_switch()
> vo_vm_close() calls free() on the global pointer vidmodes, but it
> it doesn't set vidmodes to NULL, so if vo_vm_switch() is called
> afterwards, it'll try to access the already-freed pointer (and this
> will probably cause segfault). 

Yes, thanks applied that part.

> Also, it's unclear to me, why was
> is XF86VidModeSwitchToMode() called twice in a row in vo_vm_close.
> Fixed by removing the duplicate occurance and NULL-ing vidmodes.

Dunno, they were always like this. Maybe there was some reason.
As they don't hurt i'll leave them like this.

			Attila Kinali

-- 
egp ist vergleichbar mit einem ikea bausatz fuer flugzeugtraeger
			-- reeler in +kaosu