[MPlayer-dev-eng] New inverse-telecine filter

[D Richard Felker III]

On Sat, Dec 06, 2003 at 07:00:22PM -0600, Zoltan Hidvegi wrote:
> > > > I tried x11 now, and it gives the same problem. Would you like pics?
> > > 
> > > Yes, it can help if you can upload a sample, and tell me which frame
> > > in the source it is from.  I assume you have that on every MPEG2
> > > source, right?
> > 
> > http://brightrain.aerifal.cx/~dalias/video_examples/zoli/pngs/
> > 
> > They come from lain-op-hardlaceboy.avi, starting at the beginning. I
> > think the error should be clearly visible...
> 
> Yes, that's clearly wrong, but I do not see anything like that.
> Anyways, I've found a bug, can you try the attached patch?
> 
> > > Yes, there is a command-line argument to disable mmx2 even on MMX
> > > machines, and I periodically run -vo md5 to make sure the MMX2 and C
> > > versions match, but it is true that I mostly use the MMX2 code.  Why,
> > > you suspect that the C version is wrong?  What CPU you have?
> > 
> > No, no particular reason to suspect it's wrong, except that I'm using
> > the C version and I assume you mostly use the MMX2 version. I have a
> > K6-3 and BTW I would very much appreciate MMX1 or 3DNOW support
> > instead of MMX2... :)
> 
> I'll see.  I guess the K6-III does not have psadbw and pshufw.  Also
> pavgb is missing, but there is pavgusb.  Also there are no
> pminub/pmaxub, but they are easy to reaplace.
> 
> Zoli

> --- libmpcodecs/vf_pullup2.c-save2	Sat Dec  6 18:11:27 2003
> +++ libmpcodecs/vf_pullup2.c	Sat Dec  6 18:17:27 2003
> @@ -896,7 +896,7 @@
>      if (!p->planes[0][0]) init(p, mpi);
>  
>      if (mpi->type == MP_IMGTYPE_TEMP ||
> -	(mpi->type == MP_IMGTYPE_IPB && (mpi->flags & MP_IMGFLAG_READABLE)))
> +	(mpi->type == MP_IMGTYPE_IPB && !(mpi->flags & MP_IMGFLAG_READABLE)))

This was the first thing I tried. No help. It just switches which pair
of buffers get used for I/P and which get used for B.

> -	    dmpi = vf_get_image(vf->next,mpi->imgfmt,MP_IMGTYPE_EXPORT,0,p->w, p->h);
> +	    dmpi = vf_get_image(vf->next, mpi->imgfmt, MP_IMGTYPE_EXPORT,
> +				MP_IMGFLAG_PRESERVE|MP_IMGFLAG_READABLE,
> +				p->w, p->h);

Readable and preserve flags are meaningless with export-type image.
Anyway I just tried this to make sure, and it doesn't help either...

:(

Rich