[MPlayer-dev-eng] [PATCH] Subtitles formatting
D Richard Felker III
dalias at aerifal.cx
Sun Aug 31 06:59:45 CEST 2003
On Fri, Aug 29, 2003 at 04:51:55PM -0400, D Richard Felker III wrote:
> On Fri, Aug 29, 2003 at 03:07:09PM -0400, D Richard Felker III wrote:
> > On Fri, Aug 29, 2003 at 12:42:48PM +0200, Salvatore Falco wrote:
> > > Hi all.
> > > This is a patch that changes the way in which long subtitle lines are
> > > displayed on screen. Currently, a line is displayed on a line, until it
> > > reaches the end of it, then it continues on the following and so on.
> > > This approach leads to the possibility to see very long lines at the
> > > beginning and a very short one at the end.
> > > The proposed approach has the aim to 'split' a long line into more
> > > lines, as equal in length as possible, but without increasing the number
> > > of lines, in comparison to the current approach.
> > :))))))))))))))))))))))))
> > I've been wanting this feature for a long time. I'll test the patch
> > and apply it as long as I see no obvious problems.
> And it works very nicely, except when it sig11's. Please see the
> attached file, figure out why it sig11's, and submit a fixed patch.
> BTW, it would probably be nice if you could get by with less cosmetic
> changes (reindention, spacing, etc.), but since you seem to have
> largely rewritten the relevant portion of the code it's ok imo. Just
> try to keep cosmetics minimal in the future.
Any progress? Please don't be discouraged by the bug I found -- once
it's fixed this patch should be great and I'll apply it right away.
Let me know if you don't have any time to work on it and I'll see
about fixing it myself.
More information about the MPlayer-dev-eng