[MPlayer-dev-eng] [PATCH]: framestep & tile filter.

[D Richard Felker III]

On Sat, Aug 30, 2003 at 01:48:09AM +0200, Arpi wrote:
> Hi,
> 
> > The other one (tile) does what my vo_tga does at the start: tile some images 
> > to have a big one with the small 'preview' on it.
> 
> hmm, looks ok, but you should use strtol() for int parsing, instead of
> reinventing the wheel, and use memcpy_pic() instead of reimplementint it
> called copy_plane...
> 
> also filter could support YUV formats too, the packed ones (yuy2 etc) seems
> quite trivial (handle same way as rgb16), but the planar yv12 is easy too
> 
> also the filter could support DR (by implementing get_image()), but we
> discussed this on IRC with Rich, and out-of-order decoding may emss up the
> whole thing, so it must be implemented in a very tricky/clever way.
> i'll try to do that.
> 
> > On this filter i face some problem, the worst of all is the query_format(...) 
> > function
> > 
> > Now to use the tiling with the xv output you need to put a scale filter after 
> > the tile one.
> 
> yes this is a known problem of the vf layer, not the only one :(
> the next_config() wrapper tries to insert scale filter, but it doesnt always
> work.
> 
> > The last question involve the make process.
> > 
> > If i modify a .c module in the directory libmpcodecs and i type make from the 
> > main mplayer directory the build process doesn't work (nothing to do for 
> > all!).
> > 
> > I have to type:
> > 
> > 	make -C libmpcodecs && make
> > 
> > Is regular or i missing, once, something?
> 
> yes, either 'make dep' (ro make depend) after ./configure (ala kernel),
> or touch .developer in the source root dir

No, you have to copy .libdeps (my silly hack) from the etc directory
into the main directory... BTW we should put this functionality into
the main makefile, or else try to get rid of recursive make altogether
(can be done by including a few simple rules from each subdir). See
the following paper for the reasons recursive make systems (which were
popularized by autosh*t) are "considered harmful":

http://www.pcug.org.au/~millerp/rmch/recu-make-cons-harm.html

Rich