[MPlayer-dev-eng] [PATCH] [RESEND] libdvdcss update that fixes Windows DVD playback

[Arpi]

Hi,

> > Joey sent this patch some time ago.  It ports the changes from the 
> > latest libdvdcss release to mpdvdkit2 that fix DVD playback on Windows 
> > (Cygwin and MinGW).  It has been tested by several people on 
> > mplayer-cygwin.  I haven't tested this on Linux, I don't have a DVD 
> > drive on my home machine, so some tests would be appreciated.
> > Somebody please review and/or apply this.
> 
> My tests on Linux were successful.  Say does anyone have a good idea for
> a standard set of tests for various parts of mplayer?  So that, for

I had some ideas, the testsuite dirs on mphq ftp were one of them.

> example, if I update dvdkit, there could be a standard number of things
> to test for and disc types to test on to make sure that every expected
> behavior is still there.  Easier to say than to implement.  :(

for dvdkit it's not too easy to produce such test set.
as it would mean writting several dvd discs, and OS emulators, so you can
test if the updated dvdkit still works on all bsd, win32 versions, with any
kind of region protection and silly driver firmwares (assuming you have one
of every major dvd drive types).

so, for this one the commit-and-wait-for-bugreports is much easier.

> But it would make development and committing faster.

only in very rare cases.
anyway it's called QA, quality a...?, used by big software development
companies. also the one i worked for (few years ago) had a big team
developing test suites only. and yes, this team was actually bigger and
more busy then the other team working on the actual code.
for a single line of code they had to write several lines of testing code.
but they had to do it, as later changes/fixes to the main code must be
immediatelly tested, waiting for bugreports from customer is not an option
there.


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu