[MPlayer-dev-eng] [PATCH] New audio filter: export
ajh at watri.org.au
Fri Aug 29 17:44:41 CEST 2003
Ayone against applying this?
Gustavo, it looks good, I have a few comments though:
1. In play why do you export the buffer even when it isn't full I have
added a flag so that the function only writes to the shared memory
when the buffer is filled.
2. Is it necessary to use msync in play? If you use mmap in your app as well
then it shouldn't be, cause msync only forces the buffer to be written
I have already made these two changes, so you don't have to send a new
patch. I will not apply to CVS until you reply to this mail.
Also write some docs if you have time.
> This is my first attempt to write an audio filter. Thanks to Anders I
> did :)
> This audio filter just exports data via mmap, so one can use it to do
> something useful, in my case, I wrote an "Audio Visualization" based on
> goom by now.. I want to make it plugin-able so other libs can be used.
> I called my app "MPlayer Audio Visualization", but if you care I can
> change its name... BTW, it's too alpha, but if u wish to take a look at
> it, I would be glad :) You can download it from:
> The af_export receives 2 options as arguments: <file>:<bsize> where:
> <file> == file to be mmap()ed
> <bsize> == buffer size in samples.
> By now, it only uses 2 channels, int16 format, which is the one I
> Desafio AntiZona: participe do jogo de perguntas e respostas que vai
> dar um Renault Clio, computadores, câmeras digitais, videogames e muito
> mais! www.cade.com.br/antizona
More information about the MPlayer-dev-eng