[MPlayer-dev-eng] [PATCH][PREVIEW] -wid fullscreen switching

Attila Kinali kinali at gmx.net
Mon Aug 25 20:24:40 CEST 2003

Hoi Fabian,

On Fri, 15 Aug 2003 17:41:46 +0200
Fabian Franz <FabianFranz at gmx.de> wrote:

> attached is a fixed version, which does use only one static global var more, 
> which is really necessary.
> It does work, but hm, imho its not a nice clean solution / code yet.

What would be a clean solution in your opion ?
And why didnt you implement it that way ? :)

> Also gui needs to be enhanced too, which is not so easy - at least for me ...

That's a prob, as i dont really understand what the gui is doing
(actualy i have a hard time understanding all the x11 stuff ^^' )

The thing i really dont like with your patch is that the spawnwindow
is created in the vo_x11 and vo_xv, this should really go into x11_common.c
as there are more drivers using x11 ouput (gl, gl2, xmga, xvidix...)
(btw you forgot the patch for those two files).

Next thing is, initialize both windows on init, not while switching
from windowed mode to fullscreen. (ok, that may seem only a detail,
but makes the switching itself faster)

mo hitotsu: i already had the idea to use 2 windows (one for windowed,
one for fullscreen mode) to preserve the window settings (not all
are honored by mplayer and sometimes lead to strange effects) though
never had the time/mood to implement it.
It would be nice, if you could extend your code to be always used.


			Attila Kinali

Chu beyond the blackest chu, Deeper then the deepest pika, King of pikachu who 
shines like gold on the sea of electric. I call upon thee, swear myself to thee,
Let the fools who stand before me be destroyed by the power you and I possess...
PIKASLAVE!!!               -- http://bash.org/?23393

More information about the MPlayer-dev-eng mailing list