[MPlayer-dev-eng] Re: [PATCH] win32 codec path

[Sascha Sommer]

> BTW2, vo_directx should fallback on non-overlay method even
> if -vo directx:noaccel is not given. Otherwise i needed to give
> noaccel for RGB format, wich was annoying if an RGB codec came
> in middle of a playlist :(
> Hand made patch around line 1106:
>
>         /*create the surfaces*/
>     if(Directx_CreatePrimarySurface())return 1;
> -        if (!nooverlay && Directx_CreateOverlay(image_format))
> +        if (Directx_CreateOverlay(image_format))
>         {
>                         nooverlay=1; /*overlay creation failed*/
> -                        mp_msg(MSGT_VO, MSGL_FATAL,"<vo_directx><FATAL
ERROR>can't use overlay mode: please use -vo directx:noaccel\n");
> -                        return 1;
>         }
>         if(nooverlay)
>         {
>                 if(Directx_CreateBackpuffer())
>                 {
>
>
> That should fix this stupid behaviour. Now that i think about it,
> nooverlay should probaly be reseted at the begining of config().
> Again I can't test so i can't commit :( Anyway i hope it help you.

Afair I changed this by purpose. vo directx can't fallback to nonoverlay
mode
during config because the only available format in nonoverlay mode is the
desktop pixelformat. Commenting out the return 1 will result in yuv codecs
writing to rgb buffers.

Sascha

Sascha