Fw: [MPlayer-dev-eng] [PATCH] x11 fullscreen switching

[Filip Kaliński]

On Wed, 13 Aug 2003 20:36:01 +0200
Alex Beregszaszi <alex at fsn.hu> wrote:

> Hi,
> 
> sorry for distrubing you, but I wanna get your opinion about this patch
> I wrote, becouse you're the original author of that code and you know it
> better than me!
> 
> Awaiting your reply, also you can send the reply to the list too!
> 
> Begin forwarded message:
> 
> Date: Tue, 12 Aug 2003 22:53:16 +0200
> From: Alex Beregszaszi <alex at fsn.hu>
> To: mplayer-dev-eng at mplayerhq.hu
> Subject: [MPlayer-dev-eng] [PATCH] x11 fullscreen switching
> 
> 
> Hi,
> 
> this patch implements negating support for -fstype options.
> Also it disables the old openbox hack, becouse it breaks fullscreen
> switching with newer openbox versions (2.x? & 3.x) and the 1.x are
> rarely used. From now on, openbox 1.x users _must_ provide '-fstype
> !fullscreen' to achive working fs switching. This _must_ be documented
> if the patch gets applied. Please, someone familiar with that code: read
> it, apply it, comment it!!
> 

Although I'm not working actively on MPlayer rigth now (got too little time
for it) I'm replying you with pleasure.

II think the extra feature of negaiting an option is a really good idea,
It can solve many problems! The patch tooks good, but there is a
bug, however, about 10l, i think :-)

You should look for "=<number>" after "layer" only in case of positive
"layer" option, in case of "-layer" it doesn't make sense, and what's more
it doesn't work because of looking for "=" at vo_fstype_list[i][5].

Also, I would change "strstr" to "strcmp" again with somethin like this at
begining:

if (vo_fstype_list[i][0] == '-') {
  neg = 1;
  arg = vo_fstype_list[i] + 1;
} else {
  neg = 0;
  arg = vo_fstype_list[i];
}

and later

if (strcmp(arg, "blahblah") == 0) {
  if (neg) type &= ~vo_wm_BLAHBLAH else type |= vo_wm_BLABLAH;
}

Using of "strstr" function for comparing strings is way too loose, I think.

-- 
Filip Kalinski <filon at pld.org.pl>