[MPlayer-dev-eng] Re: [NEW PATCH] ftp support

[Arpi]

Hi,

> > > first of all, I don't understand why mplayer needs such support at all.
> > The only alternative is wget ... | mplayer. But you can't seek (and need
> > wget ;)
> > 
> > > And then, why is it enabled by default?
> > 1. it doesn't depend on something special
> > 2. it should work for everybody.
> > 3. It must be tested
> 
> 4. It simply increases the binary size for all people
> 5. people who need it, can always enable it
or people who dont need it, could disable it
i dont think that few kb more really count on a 8mb binary...
or then we could disable many less important features.

> 6. did you check it if there is no buffer overflow in it?

lol :)
whole mplayer is a big buffer overflow
we could even use bugtraq to promote new releases :)

> 7. why do you we need functions like: FtpRmdir, FtpMkdir, FtpModDate,
> FtpPut, FtpRename, FtpDelete

agree
actually, why do we need ftplib, the ftp protocol is simple enough to
reimplement from scratch, using the already existing functions of network.c

> 8. 'must' is a strong word

:)))

> > > Oh, and using 'nospam at nowhere.com' is not a good idea. Thats a valid
> > > domain name.
lol

> > I think whatever you put it will become "a valid domain name" sooner

maybe it points to a spammer who collects emails this way :)

> Thanks for this attitude, please make it then not the default if you don't care
> about faking email addresses.
:))))


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu