[MPlayer-dev-eng] [PATCH] EDL 0.6 - DVD chapter support (w/ cvs diff -u)
arpi at thot.banki.hu
Tue Aug 12 20:36:41 CEST 2003
> > > It's a minor thing, but Gabu has been known to correct two spaces to
> > > one and I sometimes also do it, so if you could redo the patch that
> > > would be very nice.
> > > Thanks
> > Here it is. Supporting DVD streams while finding the appropriate
> > record after a seek was a bit tricky, but it worked with my tests.
> Are there any non dvd chapter support related changes in your patch? If
> yes, could you separate it? I think this dvd-chapter stuff should be
> left out off the release, becouse it tweaks lot in mplayer.c. Comments?
actually the whole edl should be left out, as there are separate sf project
(afaik) for that, and tehre are even different forks of the edl support
and anyway, the dvd code should be fixed to output meaningful time, instead.
(we discussed at irc, the absolute start time of each chapter is stored in
.ifo, so it can be read out at stream_dvd, and mayeb even at mpeg demuxer,
and adjust the relative mpeg-PTS timestamps by it.)
(also, afaik there is a higher range timestamp in GOP headers, better for
timing that 90khz-based syncronization PTS in mpeg PS/PES headers)
A'rpi / Astral & ESP-team
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu
More information about the MPlayer-dev-eng