[MPlayer-dev-eng] [PATCH] dvb input update
nsabbi at libero.it
Thu Aug 7 23:50:35 CEST 2003
>About the demuxer part of your patch:
>- too much cosmetics
>- i see some progress in removing namespace mess (lots of global vars)
>- ther are new, even worse 'namespace polluting' entries, like the very very
> confusing DVB-specific demux_start(), open_fe(), get_tuner_type()...
> please prefix all exported (non-static) variabne and function name with
> dvb_ or dvbin_. but it's better make them static when possible, i doubt
> you really need so much global funcs and vars. think of g2, where globals
> are not allowed at all!
>if you fix these, i'll commit the patch (the demuxer part).
following your suggestion I made static all non necessary functions,
renamed the others to dvb_* and removed all globals
variables but one: dvb_list_ptr.
Actually it's global because I need to access it from the menu code, but
I'd like to remove even that.
Is it possible to access the current stream->priv from the menu?
>A'rpi / Astral & ESP-team
>Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu
>MPlayer-dev-eng mailing list
>MPlayer-dev-eng at mplayerhq.hu
More information about the MPlayer-dev-eng