[MPlayer-dev-eng] [PATCH] softpulldown

[Arpi]

Hi,

> This patch adds a 'softpulldown' video filter. It uses the mpeg2 video
> header information to make 29.97 fps out of 23.976 fps softtelecined
> material. This should help especially for dvds which are partly
> softtelecined.

Uhh.

> Before I commit it I'd like to know if the way I added the needed flags
> to mp_image_t is ok.

Looks ok.

> BTW, while developing this I noticed that libmpdemux/mpeg_hdr.c does
> use the data in stream order and does no reordering, which means that
> the display_time adjustments are often made for the wrong frame.

mpeg PTS reodrering is done in video.c

> Two other things I noticed:
> 1) In mplayer.c, VOCTRL_DUPLICATE_FRAME is only called if
>    vo_config_count>0, but vo_config_count is not increased by the
>    yuv4mpeg output plugin.

it's increased by (and ONLY by) vf_vo.c

> 2) This filter does not work properly with vo_yuv4mpeg because
>    it supports slices and only writes a frame on flip_page.
>    AFAICS there is no big benefit to slices support in vo_yuv4mpeg
>    (As far as I understand it slices are needed for direct rendering),
>    so would it be ok to disable slices support of vo_yuv4mpeg?

no!

i don't understand how slices are related to your filter?
if your filter doesn't support slices, things still should work, vf_vo.c
does handle this case.


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu