[MPlayer-dev-eng] [PATCH]: dvb_in module fixes

[Alban Bedel]

Hi Nico,

on Mon, 28 Apr 2003 01:14:12 +0200 you wrote:

> 
> Hi,
> actually the dvb-in module is broken because of the changes in the 
> option parsing code.
Wich changes ? There where some changes a while back but it was mainly
new options type, so it shouldn't have affected this code.
But the stream opening have been hacked.

> This patch for mplayer-cvs is to restore it, clean some code, fix some 
> bugs, remove some obsolete code and to add (partial) conformance with 
> the uri syntax both in mplayer and in mencoder:
> 
> mplayer dvbin//Pro7
> mencoder dvbin://Pro7 -ovc xvid -oac copy -o film.avi -vop denoise3d

You reintroduced a cmd line parameter to enable dvbin ?
+#ifdef HAS_DVBIN_SUPPORT
+if(dvbin_param_on || (filename && !strncmp("dvbin://", filename, 8)))
+{
+

That's bad. Actually I'm trying to clean the stream stuff so that it's
possible to open sevral stream at the same time. And ultimatly it should
also be possible to open sevral stream of the same type at the same time.
Currently i finished file, cdda, vcd and null (tv,mf). imho it would be
better if you ported dvbin to the new api.
Mainly you have to replace the dvdin stuff from open.c/stream.c by the
callbacks used by the new api.
It look like this stream type have a lot of options. So not all can be
passed in the url. For such stream the currenttly existing options should
now set the "default value", so from the user pov these option just still
works. But they can still be overrided by the "per-instance" parameters.
You can look at the cdda stream as example.
Ok, options to set the "per-instance" parameters for the "main" stream
and the "audiofile" one are still missing but it not so important atm.

> There is some issue still to solve, but for the moment the code should 
> be acceptable.

I'm also wondering about the part where you touch the playtree in
mplayer.c I don't really understand what you are trying to do, but :

+		entry = play_tree_new();
+		play_tree_add_file(entry, "dvbin://");
+		list = entry;
+		play_tree_append_entry(list,entry);

is wrong.
BTW the vo's should support multiple config call so having the stream
resolution to change should be possible (if the codec support it).
But for the audio it's probably completly impossible atm.
It just that i dont tkink that it's right to have a stream type wich play
with the user playlist. But atm such a hack is probably "simpler".
	Albeu