[MPlayer-dev-eng] [PATCH] Spring cleanup

[Arpi]

Hi,

> -           while (de = readdir(d)) {
> +           while ((de = readdir(d)) != NULL) {
> 
> Basically that's really ugly. At least leave off the != NULL part

agree. double parents is the best.

> (just use the extra parens), or better yet skip the change entirely.
> IMO this warning is very misguided and is targetted as BASIC/PASCAL
> programmers; no one who really writes C confuses = and ==.

and me :)
when i wrote the new mpeg demuxer for g2, i did that idiotic mistake twice!
then i wondered why it misdetects my stream and gives always 0 for pts (some
if(pts=old_pts)...) :)


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu