[MPlayer-dev-eng] [PATCH] Spring cleanup

Raindel Shachar raindel at techunix.technion.ac.il
Mon Apr 21 02:15:01 CEST 2003


I decided to do a little cleanup in mplayer's source, so that gcc will
produce much less warnings when compiling with -Wall. I attach a patch
which fixes some of the warnings. More tomorrow.

Cheers
Shachar

P.S. I think that I spotted (and fixed in the patch) few 10l bugs in
spudec.c: it was checking if an unsigned variable which was just
calculated is SMALLER than 0 (and if it is, clipping it to 0), what can't
be. the correct code, IMHO, is to check first if the result will be
smaller than 0, what can be done faster, and only after that set it to 0,
or calculate the value needed. I found this in 4 different places, so I
think it should be counted as 40l ;-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer.diff.gz
Type: application/octet-stream
Size: 7080 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20030421/ff7da1c4/attachment.obj>


More information about the MPlayer-dev-eng mailing list