[MPlayer-dev-eng] [PATCH]: demux_ts 'spring' cleanups

D Richard Felker III dalias at aerifal.cx
Sat Apr 12 03:13:52 CEST 2003


On Sat, Apr 12, 2003 at 12:56:44AM +0200, Nico wrote:
> Hi,^M
> ^M
> the file attached is a cleaner version of demux_ts.c for today's cvs. ^M
> I didn't post the diff because it's bigger than the file itself.^M
> ^M
> All the warnings were silenced and all globals removed.^M
> ^M
> ^M
> Nico^M
> ^M
> 

If you can't send a proper email, much less a patch, how can we expect
you to write code that's not full of bugs? Hint: your mailer created
quoted-printable ^M's all over the place.

We require patches because someone has to review changes before
blindly committing code. So if you don't send a patch, someone has to
generate one for the file you sent to see what's changed.

Of course if anyone else commits changes before someone gets around to
looking at your "new version" of the code, then running diff will
remove whatever other improvements were added in between. This is very
bad. So always follow directions (!!) and send a patch!


Rich



More information about the MPlayer-dev-eng mailing list