[MPlayer-dev-eng] [PATCH] directx, typo, fs

[Sascha Sommer]

> On Sat, Apr 05, 2003 at 03:10:29PM +0200, Sascha Sommer wrote:
> > > It's a common keybinding for windows video players IMHO, so I'm going
> > > to include it in my packages anyway for the sake of those who've never
> > > used mplayer on linux and wouldn't know to hit 'f'.  I hope you find
> > > this useful enough to commit, and if not I'll still have it in my
> > > package's patch set, no hurt feelings.
> >
> > Would it help you if I commit a #if 0 ed version that calls control to
> > switch fullscreen?
> > I personally do not like the idea that the behaviour depends on which
window
> > the keyboard focus is on.
> > I like to have the console in foreground.
>
> I don't understand.  Even if I call control, it's still only the directx
> window that can recieve alt+enter.  It's no less vo-dependant that way.

I meant it is not needed to seperate toggle_fs.
Btw. this should be declared as static void toggle_fs

> The correct fix, I know, is to get the input code to be able to see
> alt+keypresses, but it doesn't.  If we define some keycodes for alt+key
> and have directx push them to the buffer, it's still only directx that
> is doing this.  The input code in it's current state would have to get
> them from each vo, and that's worse than my way, I think.  The best way
> is to patch input/ stuff, but I haven't been able to do it right yet.

Agree.

> But it doesn't matter if you don't commit this part, I'll continue to

It didn't work for me on WIN98.

> package with this patch until the right fix is done.  And I don't think
> any user who cares a lot about alt+enter in directx will be compiling
> from source anyway.  :)
>

Yes :(
At least the typo fix is in main cvs now.
Thanks,

Sascha