[MPlayer-dev-eng] [PATCH] Support for special audio keys on "multimedia" keyboards

[Alban Bedel]

Hi Jason Tackaberry,

on 03 Apr 2003 13:56:15 -0500 you wrote:

Applied to main.

> Some various comments about the attached implementation:
> 
>      1. There was no HAVE_XFREE to #ifdef, so I include X11/XF86keysym.h
>         if HAVE_XF86VM is defined.  I think this is probably fine, but
>         am not 100% certain.
I let it as is but it's not so good as HAVE_XF86VM is defined only if
you have XF86 with the VM extension. As most ppl use a recent XF86 they
will always have the VM extension. But i think that we should really add
a check in configure too know if X11 is XF86 or not.
I patch to fix this would be nice ;)

>      2. If XF86XK_AudioPause is not defined (after including
>         XF86keysym.h), MPlayer will not pay attention to the extended
>         keysyms.  This patch assumes that if XF86XK_AudioPause is
>         defined, so are the others.
It's ok imho.

>      3. 'mplayer -input keylist' will list these keys (XF86_PAUSE,
>         XF86_STOP, etc.) even if support isn't compiled into MPlayer for
>         them (in libvo/x11_common.c).  I don't imagine this is a
>         problem, since mplayer lists the JOY_* keys even though I don't
>         have a joystick.
No problem, This behaviour is intentional. Otherwise the parser chock if
you putted such key in your input.conf but your binnary don't support it
anymore.
	Albeu