[MPlayer-dev-eng] [PATCH] directx, typo, fs

[Alban Bedel]

Hi Joey Parrish,

on Wed, 2 Apr 2003 01:13:03 -0600 you wrote:

> Hello,
> 
> Attached below is a patch for vo_directx.c.  It's a patch I've just
> added to my cygwin packages, and it seemed clean enough to submit for
> approval.  It does the following:
> 
> 1) moves the fullscreen toggling code into a function called toggle_fs
> 2) fixes a small typo in the keystroke handling code
> 3) when directx window hears ALT+ENTER, toggles fullscreen status
> 
> I could have done this by pushing 'f' to mplayer's input buffer, but
> since a user may have other keybindings for 'f', this seemed bad.  I
You can add a fullscreen command in the command queue (see input/input.h).
But it's not a so good solution imho as then your driver will depend on
libinput.
> tried to figure out how to add support for ALT+whatever in keycodes.h,
> but the only such keys I found to have unique codes are ALT+0 through
> ALT+9 (0x140-0x149, IIRC).  All others generated two codes in
> succession, such as ALT+k producing 'k',0x1b for any letter like 'k'.
> Because of this, I just decided that having ALT+ENTER for fullscreen
> could probably be okay as a directx-specific feature.  (Directx, unlike
> linux console, gives a unique way to identify this.)
The input code accpect key combinations but your driver have to send
push/release events. See input/input.h too, you just have to or the keycode
to make it a push event (release is the default). Then you can use key
combinations but i don't remeber the separator used in input.conf (probably
',' rtfs ;).
Imho this would the 'right' solution, as i don't like the idea of having
again keys wich work only with vo xxx.
	Albeu