[MPlayer-dev-eng] review of mplayer application

[Colin Leroy]

On 01 Apr 2003 at 15h28, DINH Viêt Hoà wrote:

Hi,

> 1 - playlist with 100000 entries take a long to read, is there any 
> description of the philosophy of the playlist (for example, why a tree 
> and not a simple list ?) so that I can produce a patch to read it 
> faster.

Maybe read http://mplayerhq.hu/DOCS/documentation.html#command_line 
I think the key phrase is "You can group filenames/URLs together" :)
 
> 2 - filename is not freed :
> in mplayer.c 
>   filename = play_tree_iter_get_file(playtree_iter,eof);
> the string returned by play_tree_iter_get_file is never freed.
> 
> I have some quick fix :
> while(playtree_iter != NULL) {
> +  if (filename != NULL)
> +    free(filename);

i'd make it 
if (filename != NULL) {
  free(filename);
  filename = NULL;
} 

just to be sure it won't be double-freed, but maybe it's useless.

-- 
Colin
# rm * .o
rm: cannot remove `.o': No such file or directory