[MPlayer-dev-eng] Real Time Clock into timer-lx.c?

[Arpi]

Hi,

>   1. Some previous program happens to have left it at >= 256Hz.
hmm i thought it was fixed long time ago

>   2. I'm running as root, or setuid-root
it's kernel thing - you can override the 64hz limit in 2.4.19 /proc/sys/...

>   1. *Set* the RTC to 256Hz rather than accepting whatever frequency
maybe 256hz is not enough, i prefer 1024

>      than that.  Since only one application can use the RTC at a time,
>      does anyone see a problem with just putting a value in?
no

>   2. Actually look at what the RTC returns (exact count of interrupts
>      since last call) and use this to efficiently calculate
>      GetRelativeTime() instead of banging on gettimeofday.
why?

>   3. At the same time, move RTC into linux/timer-lx.c (still inside
why?

>      ifdef HAVE_RTC's of course.)  Is there a better place that
>      it might belong?  Is it OK/clean to add #include for ../mp_msg.h
>      in timer-lx.c so that the RTC code can continue to print the
>      messages it does now?
no

>   I've verified that the above can be done in a way that leaves
>   the player 100% unchanged functionally and it makes mplayer.c
>   more readable:  The exact same while loop that was used for
>   usleep is the only one needed again.  Please let me know what
>   you think.

send patch, i'll see
i agree with 1, but see no reason for 2 and 3


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu