[MPlayer-dev-eng] [PATCH] tga loader for libmpcodecs

[D Richard Felker III]

On Tue, Sep 10, 2002 at 11:02:16PM +0200, Arpi wrote:
> Hi,
> 
> > > I've finished the TGA loader, with the following modes being supported:
> > 
> > Since I haven't received any feedback on this now, I'm wondering whether there's something wrong with the patch... AFAIK I didn't break any of the rules listed in patch.txt, but you never know ;)
> 
> ok, i've checked, and commited with small changes.
> anyway, you've added BGR24 to codecs.conf too, but your code doesn't seem to
> support 24bpp output:
> 
>                     *final++ = chans.r;
>                     *final++ = chans.g;
>                     *final++ = chans.b;
>                     *final++ = chans.a = (info.bpp == 32) ? *data++ : 255;
> 
> the 4th write to final[] should not be done if mpi->bpp==24
> for now i've removed BGR24 from codecs.conf.
> 
> anyway the code could be optimized a lot, by doing memcpy() for the cases
> when input and output bpp matches.

Is it possible to use the demuxer buffer in an export-type mpi? Seems
like that would be optimal, for uncompressed tga's.

Rich