[MPlayer-dev-eng] Quick fix to new input method

[Alexander Gottwald]

On Sun, 8 Sep 2002, D J Hawkey Jr wrote:

> > No. It is not the developers' job to cater to you. If you have a
> > feature you want included, then you should take the trouble to make an
> > acceptable patch that applies cleanly to latest cvs. Don't expect
> > someone else to try to figure your mess out when patch bombs with
> > rejects.
> 
> Those are the rules, yes. I wasn't asking to be catered to, I handed them
> a fix to their stuff. Maybe not even an appropriate fix, but a fix, and
> an easy one, at that. The "mess" you write of is a one-line change.

You want the bug fixed too? Then please help the developer and send clean
patches. If the submited patch does not cleanly apply to cvs, it is likely
to be delayed or even rejected.

> >> In many instances, I think an "inline" inclusion of a patch should be just
> > 
> > No, inline patches will often get tabs/spaces messed up by mailers,
> > and then they don't apply cleanly.
> 
> For large and/or "complex" patches, yes, I agree. I wrote of small patches,
> as mine was. Even OE wouldn't mangle that patch so badly that it wouldn't
> apply cleanly. I'm certain patches aren't applied blind; a developer would
> have at least looked a small patch over, as he read the mail, right? He
> could then ditch it if he wanted to, as opposed to a hard-and-fast rule.

See point one. Tabs and linebreaks _will_ break the patch. 

bye
	ago
-- 
 Alexander.Gottwald at informatik.tu-chemnitz.de 
 http://www.gotti.org           ICQ: 126018723