[MPlayer-dev-eng] [BUG][PATCH] in ffmpeg12 MPEG1 decoding + mencoder

[Arpi]

Hi,

> On Thursday 05 September 2002 10:34, gabucino at mplayerhq.hu wrote:
> > mplayer -vc ffmpeg12 has garbled decoded picture when decoding an MPEG1
> > AVI encoded with mencoder. Also it's faster that libmpeg2 decoding on the
> > same file (which works).
> >
> > mplayer -vc ffmpeg12 can decode any other MPEG1 file. Only MEncoder created
> > files (AVI!) are buggy.
> end of frame (0x1FF) startcodes are not added for mpeg in avi though they are 
> added for real mpeg, i attached a possible fix, can someone who understands 
> video.c (arpi, alex, ?) check, if its ok then ill commit it

hmm.
the 0x1ff is not standard thing, ffmpeg12 should not rely on that.
it was added by me long time ago as a hack to get libmpeg2's builtin mpeg-ps
demuxer out. maybe it should be moved to vd_libmpeg2.c now, or can be
removed, as i've replaced decode.c of libmpeg2 so it has no any use now.
i'll check this.

the patch looks ok, but again: imho it isn't the right fix.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu