[MPlayer-dev-eng] Re: [PATCH] error checking for lavc stats_file writing

[Arpi]

Hi,

> > If you don't check, you end up with a corrupted stats file with no
> > indication that something bad happened (i.e., exit status == 0). How
> > is this better?
right.... but

> imho put_image() should not call exit(), just imaging fprintf() would call 
> exit internally, it would be annoying too ...
agree

> the solution would be to set some global flag, print an error message in 
> put_image() and check this flag somewhere in mencoder.c and exit there

actually the opening/reading/writing this 2-pass log file should be done in
mencoder.c instead of ve_*.c, just like for divx4 codec.
we could kill vpass and use the common -pass option, which already
implements opening/writing this file.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu