[MPlayer-dev-eng] [PATCH] small ogg softsub fixes

[Piotr Krukowiecki]

On Wed, Aug 28, 2002 at 08:05:29PM +0200, Arpi wrote:
> Hi,
> 
> > > Attached patch 
> > > - fixes problems when new line is just '\n' and not '\r\n'.
> > ok
> dunno.
> the author of teh original ogg subtitle support patch wrote a comment about
> \n are not newline in ogg subs, but \r is. i found it strange but accept it.

I don't know what he meant too...

> > > - disables code that removes html tags from subs (the code was not
> > >   functional anyway)
> > instead that removed the outcomming of if (!ignored)
> ok

I didn't used that code because i'm not sure how the subtitle looks like
if i want to use literal '<' or '>' in it. Maybe it's using html tags
(&gt; etc), but maybe not. Never seen subtitle with those characters.

Anyway, the 
        case '>':
          ignoring = 0;
          break;
should be probably
        case '>':
          if (ignoring)
          {
            ignoring = 0;
            break;
          }

This could help find cases when '>' is '>' and not '&gt;' or whatever.
 

> > > - increases SUB_MAX_TEXT. I have movie that has 6 lines of text in one
> > >   scene.
[...]
> it's ok to increase.

Was still not increased in 20020830

> anyway a 6+ line subtitle covers the whole movie :)
> it's more like teletext than subtitle :)

Not true, 6 line subtitle takes only 20% of screen :)


-- 
Piotrek  (@ ~)
Mors Drosophilis melanogastribus!