[MPlayer-dev-eng] some funny stuff in asf_mmst_streaming.c

[Jindrich Makovicka]

Bertrand Baudet wrote:

>On Monday 28 October 2002 04:52 pm, Jindrich Makovicka wrote:
>  
>
>>@@ -671,11 +675,13 @@
>>                        mp_msg(MSGT_NETWORK,MSGL_DBG2,"Response [%s]\n",
>>http_hdr->buffer ); }
>>                streaming_type = asf_http_parse_response(http_hdr);
>>+/*
>>                if( streaming_type<0 ) {
>>                        mp_msg(MSGT_NETWORK,MSGL_ERR,"Failed to parse
>>header\n"); http_free( http_hdr );
>>                        return -1;
>>                }
>>+*/
>> 
>>    
>>
>
>Why did you comment that?
>
Oops.. that was the bad cure. The good one would be assigning the result 
of asf_http_parse_response to an int instead of enum or adding -1 to 
enum ASF_StreamType_e. The point is that ASF_StreamType_e is unsigned so 
-1 gets discarded.

-- 
Jindrich Makovicka