[MPlayer-dev-eng] [PATCH] afmt.h

[Arpi]

Hi,

> > > Those lines seems to have ben patched in to make oss work on OpenBSD; see
> > > http://mplayerhq.hu/pipermail/mplayer-dev-eng/2002-April/007335.html
> > 
> > i can't see the relation
> > that patch added #ifdef SOUNDCARD_H, and it was ok.
> 
> It seems to me as if the purpose of it was to get oss_audio to work, but i
> can be wrong.
wrong
it's included to define the standard AFMT_* constants.
nothing OSS specific

> > does this patch fixes any compilation error? i can't imagine, but possible.
> > or was it just cosmetics?
> 
> It won't compile (or rather link) if --disable-ossaudio is used.

why?
then the HAVE_SOUNDCARD_H detection should fail, or configure is buggy.
if soundcard.h is there (HAVE_SOUNDCARD_H detection) then it's there, so
including it shouldn't be a problem. or is it?

> I could fix it in configure (by undefing HAVE_SOUNDCARD_H if --disable-ossaudio
> is specified) if you prefer that.
no
i prefer fixing the reason of the problem, not workarounding it

cat > $TMPC << EOF
#include <soundcard.h>
int main(void) { return 0; }
EOF
_soundcard=no
cc_check && _soundcard=yes
if test "$_soundcard" = yes ; then
  _def_soundcard='#define HAVE_SOUNDCARD_H 1'
  _inc_soundcard='#include <soundcard.h>'
else
  _def_soundcard='#undef HAVE_SOUNDCARD_H'
fi

this looks ok to me.
so if it detects it, then it shouldn't fail at compile time.
what's the error when it fail?


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu