[MPlayer-dev-eng] release tomorrow (Thursday) ?

[Arpi]

Hi,

> > ah yes
> > i put it to my delay queue.
> > my problems at first look:
> > - the patch has big indent change
> 
> Sorry, I try to keep the original indent style (four spaces no ?)

i mean you shifted big amount of code with no reason:

-       int dummy, interval, prefer_blank, allow_exp;
-       XGetScreenSaver(mDisplay, &dummy, &interval, &prefer_blank,&allow_exp);
-       XSetScreenSaver(mDisplay, timeout_save, interval,prefer_blank, allow_ex
-       XGetScreenSaver(mDisplay, &timeout_save,&interval, &prefer_blank, &allo
...
+    else
+    {
+        if (timeout_save)
+        {
why not:  else if (timeout_save) {  ?

+            int dummy, interval, prefer_blank, allow_exp;
+           XGetScreenSaver(mDisplay, &dummy, &interval, &prefer_blank,&allow_e
+            XSetScreenSaver(mDisplay, timeout_save, interval,prefer_blank, all
+            XGetScreenSaver(mDisplay, &timeout_save,&interval, &prefer_blank,

i also see no sense of having the standard XGetScreenSaver/XSetScreenSaver
method disabled when dcop method succedded.

> > - it must be optional, maybe together with -stop-xscreensaver or maybe
> >   -stop-kdescreensaver
> 
> Actually it is with -stop-xscreensaver option.

it isn't
you don't check for value of stop_xscreensaver when calling to dcop.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu