[MPlayer-dev-eng] [PATCH] fix handling of XVideo COLORKEY attributes

[Arpi]

Hi,

> Since I'm seeing the bug, I tried fixing it using each of these 
> approaches.  Either one fixes the problem just fine.  I really don't 
> know XVideo well at all, and I certainly don't know it well enough to 
> decide which fix is preferable.  So I'm attaching *two* patches below. 
> The first uses the XV_AUTOPAINT_COLORKEY approach, while the second uses 
> the approach of changing the window background.  Again, both are tested, 
> and either one fixes the bug.
> 
> If one of you developers has reason to prefer one over the other, please 
> grab your favorite and check it in.

I wanted to include both patches (so we could be 200% sure it's fixed :))
but it turned out that the bg color == colorkey method is buggy with matrox
Xv, producing blue line at the bottom of the screen in fullscreen mode.
So only the XV_AUTOPAINT_COLORKEY approach is applied for now.

> Incidentally, somebody should probably tell the SDL people about this, 
> as "-vo sdl:x11" has exactly the same problem.

Atmos?


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu